Re: [PATCH v3 0/4] x86/of: Fix a bug in x86 arch OF support

[Rahul Tanwar]

On 22/11/2022 6:15 pm, Andy Shevchenko wrote:
> This email was sent from outside of MaxLinear.
> 
> On Tue, Nov 22, 2022 at 09:49:04AM +0000, Rahul Tanwar wrote:
>  > On 22/11/2022 5:18 pm, Andy Shevchenko wrote:
>  > > On Tue, Nov 22, 2022 at 03:39:06PM +0800, Rahul Tanwar wrote:
>  > >
>  > >> Rahul Tanwar (4):
>  > >> x86/of: Convert Intel's APIC bindings to YAML schema
>  > >> x86/of: Introduce new optional bool property for lapic
>  > >
>  > > You need properly prefix the first two patches. I guess it's 
> something like
>  > > "dt-bindings: x86: ioapic:".
>  > >
>  >
>  > Yes, i just checked the git log of devicetree.c and used same prefixes
>  > here. Thanks for correcting it. I will update it.
> 
> Moreover the Cc list in those patches is quite wrong.
> 
> I recommend to utilize my "smart" script [1] for sending series.
> (You may take an idea from it how to prepare the Cc list close to proper 
> one)
> 
> [1]: 
> https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh 
> <https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh>
>

Agree on the Cc list being wrong. Thanks for the script.

Quite useful. Could not understand how the script works for multiple 
commits when you take count & version as inputs. Also, where does it 
create patches (format-patch)? It seems to get suitable to & cc list & 
send emails to them. And the input is COMMIT_HASH. How do i use it for a 
series with multiple commits & do i have to create patches on my own? 
Thanks again.

Regards,
Rahul


> -- 
> With Best Regards,
> Andy Shevchenko
>