RE: [PATCH 1/1] tpm/tpm_crb: Fix error message in __crb_relinquish_locality()

[Michael Kelley (LINUX)]

From: Winkler, Tomas <tomas.winkler@xxxxxxxxx> Sent: Saturday, November 12, 2022 11:33 AM
> > -----Original Message-----
> > From: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> > Sent: Friday, November 11, 2022 21:39
> > To: peterhuewe@xxxxxx; jarkko@xxxxxxxxxx; jgg@xxxxxxxx; Winkler, Tomas
> > <tomas.winkler@xxxxxxxxx>; linux-integrity@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx
> > Cc: mikelley@xxxxxxxxxxxxx
> > Subject: [PATCH 1/1] tpm/tpm_crb: Fix error message in
> > __crb_relinquish_locality()
> >
> > The error message in __crb_relinquish_locality() mentions requestAccess
> > instead of Relinquish. Fix it.
> >
> > Fixes: 888d867df441 ("tpm: cmd_ready command can be issued only after
> > granting locality")
> > Signed-off-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> Acked-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>

Is there a maintainer who can pick up this fix?  It's not time critical; I'm
just trying to make sure it doesn't get lost.

Thanks,

Michael

> 
> > ---
> >  drivers/char/tpm/tpm_crb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index
> > 1860665..65f8f17 100644
> > --- a/drivers/char/tpm/tpm_crb.c
> > +++ b/drivers/char/tpm/tpm_crb.c
> > @@ -252,7 +252,7 @@ static int __crb_relinquish_locality(struct device *dev,
> >  	iowrite32(CRB_LOC_CTRL_RELINQUISH, &priv->regs_h->loc_ctrl);
> >  	if (!crb_wait_for_reg_32(&priv->regs_h->loc_state, mask, value,
> >  				 TPM2_TIMEOUT_C)) {
> > -		dev_warn(dev, "TPM_LOC_STATE_x.requestAccess timed
> > out\n");
> > +		dev_warn(dev, "TPM_LOC_STATE_x.Relinquish timed
> > out\n");
> >  		return -ETIME;
> >  	}
> >
> > --
> > 1.8.3.1