Re: [PATCH v5 4/4] media: platform: Add Renesas RZ/G2L CRU driver
From: Sakari Ailus
Date: Tue Nov 22 2022 - 14:31:23 EST
Hi Prabhakar,
On Tue, Nov 22, 2022 at 10:26:28AM +0000, Lad, Prabhakar wrote:
> Hi Sakari,
>
> On Tue, Nov 22, 2022 at 9:38 AM Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> >
> > Hi Prabhakar,
> >
> > On Wed, Nov 02, 2022 at 12:43:29AM +0000, Prabhakar wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > >
> > > Add v4l driver for Renesas RZ/G2L Camera data Receiving Unit.
> > >
> > > Based on a patch in the BSP by Hien Huynh
> > > <hien.huynh.px@xxxxxxxxxxx>
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Laurent's comment arrive a little late but the patch does not compile
> > against the media tree anymore. The argument of the media_pipeline_start()
> > and media_pipeline_stop() is now a pad, not an entity. See what the changes
> > look like in other drivers (the commit id is
> > 12cecbf9150f67b0ce7d88bc2e243e67637726c2).
> >
> I'll go through them soon, when do you plan to close the v6.2 window?
>
> > I'll still take the DT binding patches.
> >
> Or maybe we could wait and get them alongside the drivers?
Can you send a new version by tomorrow morning (Finnish time)? The needed
changes didn't seem too complicated, I wouldn't want to delay my PR much
later as chances slipping to 6.3 will increase.
--
Kind regards,
Sakari Ailus