Re: [PATCH] leds: leds-wm831x-status: init chip_pdata before access

From: Shuah Khan
Date: Tue Nov 22 2022 - 17:39:43 EST


On 11/22/22 14:05, Pavel Machek wrote:
Hi!

wm831x_status_probe() accesses status from chip_pdata before
initializing it. Fix it.

Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

Does it? ARRAY_SIZE() will be compile-time constant, no?

What is the bug? Did you test the code?


Is ARRAY_SIZE() safe when accessing the status chip_pdata->status?
I wasn't sure. If so, this change isn't necessary.

thanks,
-- Shuah