Re: [PATCH v2 2/7] HID: add mapping for camera access keys

From: Dmitry Torokhov
Date: Tue Nov 22 2022 - 20:56:36 EST


On Tue, Nov 15, 2022 at 09:33:49PM +0100, Hans de Goede wrote:
> Hi Dmitry,
>
> On 10/29/22 14:03, Eray Orçunus wrote:
> > HUTRR72 added 3 new usage codes for keys that are supposed to enable,
> > disable and toggle camera access. These are useful, considering many
> > laptops today have key(s) for toggling access to camera.
> >
> > This patch adds new key definitions for KEY_CAMERA_ACCESS_ENABLE,
> > KEY_CAMERA_ACCESS_DISABLE and KEY_CAMERA_ACCESS_TOGGLE. Additionally
> > hid-debug is adjusted to recognize this new usage codes as well.
> >
> > Signed-off-by: Eray Orçunus <erayorcunus@xxxxxxxxx>
> > Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> I have rejected the drivers/platform/x86 patch which depends
> on this, because it changes current behavior, potentially
> breaking userspace.
>
> Since this means I won't be taking any patches depending on
> this I believe it is best if this is merged through the input tree.
>
> Note this also has a:
>
> Acked-by: Jiri Kosina <jkosina@xxxxxxx>
>
> tag given in this email thread.

OK, I picked it up.

Thanks.

--
Dmitry