Re: [PATCH] usb: musb: remove extra check in musb_gadget_vbus_draw

[Tony Lindgren]

* Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> [221122 16:01]:
> On Mon, Nov 14, 2022 at 10:59:47AM +0200, Ivaylo Dimitrov wrote:
> > The check for musb->xceiv->set_power duplicates the check done in
> > usb_phy_set_power(). Moreover, not calling usb_phy_set_power() results in
> > current USB config max current not being propagated through usb_charger FW
> 
> What does "FW" mean here?
> 
> > 
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx>
> > ---
> >  drivers/usb/musb/musb_gadget.c | 2 --
> >  1 file changed, 2 deletions(-)
> 
> And is this a bugfix?  If so, what commit id does it fix?  Should it go
> to stable kernels?  What hardware was this tested on that this solved a
> problem for?
> 
> Please fix this and send a v2.

Ivaylo please also test with the musb phy changes in Linux next that might
affect this patch.

Regards,

Tony