Re: [PATCH v3 0/4] x86/of: Fix a bug in x86 arch OF support

[Rahul Tanwar]

On 22/11/2022 8:42 pm, Andy Shevchenko wrote:
> This email was sent from outside of MaxLinear.
> 
> On Tue, Nov 22, 2022 at 10:45:12AM +0000, Rahul Tanwar wrote:
>  > On 22/11/2022 6:15 pm, Andy Shevchenko wrote:
>  > > On Tue, Nov 22, 2022 at 09:49:04AM +0000, Rahul Tanwar wrote:
> 
> ...
> 
>  > > I recommend to utilize my "smart" script [1] for sending series.
>  > > (You may take an idea from it how to prepare the Cc list close to 
> proper
>  > > one)
>  > >
>  > > [1]:
>  > > 
> https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh 
> <https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh>
>  >
>  > Agree on the Cc list being wrong. Thanks for the script.
>  >
>  > Quite useful. Could not understand how the script works for multiple
>  > commits when you take count & version as inputs.
> 
> It starts from the commit <COMMIT_HASH>~$count and goes up. So it's 
> basically
> depth from the given commit (<COMMIT_HASH>).
> 
>  > Also, where does it
>  > create patches (format-patch)? It seems to get suitable to & cc list &
>  > send emails to them. And the input is COMMIT_HASH. How do i use it for a
>  > series with multiple commits & do i have to create patches on my own?
> 
> It creates patches automatically in the same was as it's done by
> `git format-patch`. That's why it accepts a lot of the parameters
> which you usually add there.
> 
> Typical use for the series is
> 
> ge2maintainer.sh -v 1 -c 4 HEAD~0 --annotate --cover-letter
> 
> Note, that your editor should be able to handle several files to edit
> (e.g. vim supports that mode).
> 


The script worked like a charm. Very useful. Thanks. But i missed to CC 
you while using the script. I have addressed all your concerns and 
already sent v4. Request to please review the series starting from below 
link:
https://lore.kernel.org/all/20221123093820.21161-1-rtanwar@xxxxxxxxxxxxx/

Regards,
Rahul

> -- 
> With Best Regards,
> Andy Shevchenko
>