Re: [PATCH V5 4/4] arm64: dts: meson: add S4 Soc Peripheral clock controller in DT

[Yu Tu]

On 2022/11/23 21:02, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 23/11/2022 12:27, Yu Tu wrote:
> > Hi Krzysztof,
> > 	
> > On 2022/11/23 18:10, Krzysztof Kozlowski wrote:
> > > [ EXTERNAL EMAIL ]
> > >
> > > On 23/11/2022 03:13, Yu Tu wrote:
> > > > Added information about the S4 SOC Peripheral Clock controller in DT.
> > > >
> > > > Signed-off-by: Yu Tu <yu.tu@xxxxxxxxxxx>
> > > > ---
> > > >    arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 26 +++++++++++++++++++++++
> > > >    1 file changed, 26 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > > > index bd9c2ef83314..e7fab6e400be 100644
> > > > --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > > > +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> > > > @@ -6,6 +6,8 @@
> > > >    #include <dt-bindings/interrupt-controller/irq.h>
> > > >    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > > >    #include <dt-bindings/gpio/gpio.h>
> > > > +#include <dt-bindings/clock/amlogic,s4-pll-clkc.h>
> > > > +#include <dt-bindings/clock/amlogic,s4-peripherals-clkc.h>
> > > >    
> > > >    / {
> > > >    	cpus {
> > > > @@ -100,6 +102,30 @@ clkc_pll: clock-controller@8000 {
> > > >    				#clock-cells = <1>;
> > > >    			};
> > > >    
> > > > +			clkc_periphs: clock-controller {
> > > > +				compatible = "amlogic,s4-peripherals-clkc";
> > > > +				reg = <0x0 0x0 0x0 0x49c>;
> > >
> > > This is broken... did you check for warnings?
> > Yes, i do.
> > You can have a look at the results of my test, as follows.
> >
> > total: 0 errors, 0 warnings, 0 checks, 38 lines checked
> >
> > ../patch_clk_v5_1122/0004-arm64-dts-meson-add-S4-Soc-Peripheral-clock-controll.patch
> > has no obvious style problems and is ready for submission.
>
> This is a checkpatch output. I am talking about DTS broken. dtc should
> warn you.

Do you mean I will have wraning in compiling?
I actually compiled without warning.
ccf$ make ARCH=arm64 dtbs -j12
  DTC     arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dtb

> Best regards,
> Krzysztof
>
> .