Re: [PATCH 09/11] blk-throttle: remove unnecessary check for validation of limit index
From: Tejun Heo
Date: Wed Nov 23 2022 - 13:32:58 EST
On Wed, Nov 23, 2022 at 02:03:59PM +0800, Kemeng Shi wrote:
> We always keep limit index valid as following:
> Max limit is always valid and low limit can only be invalidated in
> blk_throtl_update_limit_valid. Each time low limit may become invalid
> after blk_throtl_update_limit_valid is called, we will check and make
> sure current limit index is valid.
>
> It's reasonable to always keep limit index valid, so we can remove this
> check.
It's not obvious to me that it's correct and I'm not sure what we're gaining
by removing this while risking subtle breakages.
--
tejun