RE: [patch V2 21/33] genirq/msi: Provide msi_domain_alloc_irq_at()

From: Tian, Kevin
Date: Wed Nov 23 2022 - 21:55:06 EST


> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Sent: Monday, November 21, 2022 10:38 PM
>
> For supporting post MSI-X enable allocations and for the upcoming PCI/IMS
> support a seperate interface is required which allows not only the

s/seperate/separate/

>
> The function also takes an optional @cookie argument which is of type union
> msi_dev_cookie. This cookie is not used by the core code and is stored in

no msi_dev_cookie.

>
> +/*
> + * Constant to be used for dynamic allocations when the allocation
> + * is any free MSI index (entry in the MSI-X table or a software
> + * managed index.

miss a parenthesis in the end.

> + *
> + * This requires a MSI interrupt domain which lets the core code manage
> the
> + * MSI descriptors.
> + *
> + * Return: struct msi_map
> + *
> + * On success msi_map::index contains the allocated index number and
> + * msi_map::virq the corresponding Linux interrupt number

msi_map::virq 'contains' the...